Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove NestedScrollViews in Move & MenuDrawer fragments #1989

Merged
merged 132 commits into from
Aug 7, 2024
Merged

Remove NestedScrollViews in Move & MenuDrawer fragments #1989

merged 132 commits into from
Aug 7, 2024

Conversation

KevinBoulongne
Copy link
Contributor

We had RecyclerViews with disabled recycling, nested in NestedScrollViews.
That was causing lag & crashes.

The NestedScrollViews have been removed.

@KevinBoulongne KevinBoulongne added the feature Add a new function or capability to the project label Jul 31, 2024
@KevinBoulongne KevinBoulongne requested a review from a team July 31, 2024 10:56
@KevinBoulongne KevinBoulongne added the quick A pull request consisting of a few lines label Jul 31, 2024
@KevinBoulongne KevinBoulongne enabled auto-merge July 31, 2024 10:58
@KevinBoulongne KevinBoulongne disabled auto-merge July 31, 2024 11:28
@KevinBoulongne KevinBoulongne force-pushed the nested-scroll-views branch 2 times, most recently from 9dd588f to dd5dc50 Compare August 5, 2024 04:29
This was referenced Aug 5, 2024
Merged
Merged
@KevinBoulongne KevinBoulongne marked this pull request as draft August 6, 2024 11:10
auto-merge was automatically disabled August 6, 2024 11:10

Pull request was converted to draft

@KevinBoulongne KevinBoulongne force-pushed the nested-scroll-views branch 3 times, most recently from 0d90e8d to a8f9317 Compare August 7, 2024 06:19
@KevinBoulongne KevinBoulongne marked this pull request as ready for review August 7, 2024 12:46
KevinBoulongne and others added 24 commits August 7, 2024 14:46
@KevinBoulongne
Remove now useless @Suppress("MayBeConstant")
76fca84
@KevinBoulongne
Remove duplicated onClickListener
c194c97
@KevinBoulongne
Use buildList { … }
6470c1e
@KevinBoulongne
Factorize Folders sorting
8bcb528
@LunarX @KevinBoulongne
Turn objects into view holders for MenuDrawerAdapter
887a4a2
@KevinBoulongne
Format code
d3d7f56
@KevinBoulongne
Move MenuDrawer list computation to background thread
a741eb3
@KevinBoulongne
Replace mutableListOf with buildList
7fd9a46
@TommyDL-Infomaniak @KevinBoulongne
Improve Folder sorting
d561cd4
@KevinBoulongne
Organize MenuDrawer Adapter's code
0383218
@KevinBoulongne
Merge ItemType & ViewType together
d70a915
@KevinBoulongne
Make MenuDrawer advanced actions items in the RecyclerView
bd820f9
@KevinBoulongne
Typo in changelog
79390ce
@KevinBoulongne
Regroup noop items together in MenuDrawerAdapter's `areContentsTheSam…
92add40 
…e()`
@KevinBoulongne
Move binding casts to their own ViewHolders
b8cdd21
@KevinBoulongne
Moved Actions creation to static instances values
6244b5f
@KevinBoulongne
Override binding in MenuDrawerViewHolder to directly cast it into the…
814eb8d 
… correct type
@KevinBoulongne
Rename MenuDrawerAdapter actions
87eb648
@KevinBoulongne
Remove now useless temporary booleans
4758183
@LunarX @KevinBoulongne
Split menu drawer list formatting into sub functions
fe6e721
@LunarX @KevinBoulongne
Fix custom folders subfolders being ignored
ea7c491
@LunarX @KevinBoulongne
Split the realm query to only loop on meaningful folders
cce0e3e
@LunarX @KevinBoulongne
Clean and optimize menu drawers flows
2b003fb
@KevinBoulongne
Some cleaning in DefaultFolders & CustomFolders querying in Realm
acd1034
@KevinBoulongne KevinBoulongne disabled auto-merge August 7, 2024 12:48
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Aug 7, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@KevinBoulongne KevinBoulongne merged commit e4c390a into master Aug 7, 2024
4 checks passed
@KevinBoulongne KevinBoulongne deleted the nested-scroll-views branch August 7, 2024 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@KevinBoulongne KevinBoulongne

Labels
feature Add a new function or capability to the project quick A pull request consisting of a few lines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@KevinBoulongne @tevincent @LunarX @TommyDL-Infomaniak